Fix nginx configs #12140
Closed
Fix nginx configs #12140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nginx config for SSL didn't match the one for non-SSL, so things didn't work as expected. Simply copied the default one to the SSL one, re-adding the few ssl options required.
|
@gcglinton can you please make a new PR into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nginx config for SSL doesn't match the one for non-SSL, so things don't work as expected.
Copied the default one to the SSL one, re-adding the few directives/parameters required to make SSL work.
Also standardized indentation for the default nginx config; some blocks had only two spaces, but elsewhere it was 4. Now it's 4 everywhere.
Description
The nginx config that's used when enabling SSL is missing some
locationblocks, and it causes the apps to not load.Addresses:
Documentation