Package version from env instead of package.json #12139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #12139 +/- ##
==========================================
+ Coverage 75.53% 76.28% +0.75%
==========================================
Files 334 429 +95
Lines 13981 16138 +2157
Branches 2936 3254 +318
==========================================
+ Hits 10560 12311 +1751
- Misses 3200 3581 +381
- Partials 221 246 +25 see 95 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adrinr
commented
Oct 23, 2023
| @@ -75,12 +75,12 @@ function getPackageJsonFields(): { | |||
| const content = readFileSync(packageJsonFile!, "utf-8") | |||
| const parsedContent = JSON.parse(content) | |||
| return { | |||
| VERSION: parsedContent.version, | |||
| VERSION: process.env.VERSION || parsedContent.version, | |||
There was a problem hiding this comment.
This will use the env variable version if set
adrinr
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reading package version from environment instead of relying on the package.json for the docker images V2. As we don't have npm repo dependencies anymore, the package.json will always have 0.0.0.
This will only apply to the new images, currently only used in QA
Related: https://github.com/Budibase/budibase-deploys/pull/134