Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes and tweaks #12129

Merged
merged 7 commits into from
Oct 20, 2023
Merged

CI fixes and tweaks #12129

merged 7 commits into from
Oct 20, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Oct 20, 2023

Description

  1. Cleaning some dev code from pipelines
  2. Using nx-affected always on PR
  3. Fixing single image v2 after changes on the removeWorkspaceDependencies.sh script

@adrinr adrinr added the firestorm Data/Infra/Revenue Team label Oct 20, 2023
@adrinr adrinr requested a review from mike12345567 October 20, 2023 12:05
@adrinr adrinr enabled auto-merge October 20, 2023 12:05
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #12129 (91b7994) into master (89d6486) will decrease coverage by 10.27%.
The diff coverage is n/a.

❗ Current head 91b7994 differs from pull request most recent head 5cc3141. Consider uploading reports for the commit 5cc3141 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           master   #12129       +/-   ##
===========================================
- Coverage   67.62%   57.36%   -10.27%     
===========================================
  Files         499      259      -240     
  Lines       19790     7953    -11837     
  Branches     4101     1483     -2618     
===========================================
- Hits        13383     4562     -8821     
+ Misses       5927     3107     -2820     
+ Partials      480      284      -196     

see 430 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr disabled auto-merge October 20, 2023 13:20
@adrinr adrinr changed the title Cleaning pipeline CI fixes and tweaks Oct 20, 2023
@adrinr adrinr enabled auto-merge October 20, 2023 13:23
@adrinr adrinr merged commit 431f683 into master Oct 20, 2023
10 checks passed
@adrinr adrinr deleted the clean-pipeline branch October 20, 2023 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants