-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving typing of external row API #12100
Conversation
…lications throughout the row API and SDK, cleaning up where possible based on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much clearer, thanks for sorting this Michael! 🙏
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #12100 +/- ##
==========================================
+ Coverage 68.50% 75.37% +6.86%
==========================================
Files 585 326 -259
Lines 21839 13904 -7935
Branches 4409 2931 -1478
==========================================
- Hits 14961 10480 -4481
+ Misses 6364 3198 -3166
+ Partials 514 226 -288
... and 260 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
Improving the typing around the
ExternalRequest
object, which has implications throughout the row API and SDK, cleaning up where possible based on it.The main change here is making sure that
Operation.READ
has a specific response (as it already did) and all other operations have their own specific response (as they already did). The types just did not allow for this knowledge to be fully transferred through the layers, requiring some gymnastics when using the class.Feature branch env
Feature Branch Link