Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for grid blocks #12086

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Add template for grid blocks #12086

merged 3 commits into from
Oct 26, 2023

Conversation

Ghrehh
Copy link
Contributor

@Ghrehh Ghrehh commented Oct 17, 2023

Description

Adds a button to create a page with a grid block for a selected data source

Addresses:
https://linear.app/budibase/issue/BUDI-7391/screen-template-grid-block

Feature branch env

Feature Branch Link

@Budibase Budibase deleted a comment from github-actions bot Oct 17, 2023
@Ghrehh Ghrehh force-pushed the grid-block-template branch from 59e9125 to 9971b39 Compare October 19, 2023 09:03
@Ghrehh Ghrehh changed the base branch from develop to master October 19, 2023 09:03
@Budibase Budibase deleted a comment from github-actions bot Oct 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #12086 (33ff807) into master (91d6130) will increase coverage by 7.07%.
The diff coverage is n/a.

❗ Current head 33ff807 differs from pull request most recent head 4141c31. Consider uploading reports for the commit 4141c31 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #12086      +/-   ##
==========================================
+ Coverage   68.46%   75.53%   +7.07%     
==========================================
  Files         594      335     -259     
  Lines       21964    13990    -7974     
  Branches     4420     2936    -1484     
==========================================
- Hits        15037    10568    -4469     
+ Misses       6414     3201    -3213     
+ Partials      513      221     -292     

see 262 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Ghrehh Ghrehh force-pushed the grid-block-template branch from f79db35 to 8875081 Compare October 23, 2023 10:29
@Ghrehh Ghrehh force-pushed the grid-block-template branch from 8875081 to 4141c31 Compare October 25, 2023 13:23
@MihailHadzhiev2022
Copy link
Contributor

LGTM

@Ghrehh Ghrehh merged commit 5909b4a into master Oct 26, 2023
10 checks passed
@Ghrehh Ghrehh deleted the grid-block-template branch October 26, 2023 10:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants