-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Button group component #12057
New Button group component #12057
Conversation
…ehaviour. Refactoring and renaming of EditComponentPopoever component
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #12057 +/- ##
==========================================
- Coverage 74.39% 74.37% -0.02%
==========================================
Files 326 326
Lines 13939 13941 +2
Branches 2937 2937
==========================================
- Hits 10370 10369 -1
- Misses 3328 3331 +3
Partials 241 241
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a few comments to explain the changes I've just made and pushed up, as we discussed.
...ilder/src/components/design/settings/controls/ButtonConfiguration/ButtonConfiguration.svelte
Show resolved
Hide resolved
...ilder/src/components/design/settings/controls/ButtonConfiguration/ButtonConfiguration.svelte
Show resolved
Hide resolved
...ilder/src/components/design/settings/controls/ButtonConfiguration/ButtonConfiguration.svelte
Show resolved
Hide resolved
...ilder/src/components/design/settings/controls/ButtonConfiguration/ButtonConfiguration.svelte
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
c06ee74
to
ddda57f
Compare
LGTM |
Description
Added a new
Button group
component to theBasic
component section in the builder.Addresses:
Screenshots
The
Button group
and its default buttons.When you click on the
Cog
icon you can fully configure the buttons as you would expect with theButton
config modal. Click and hold on the entry on the list to rearrange the button order.Building a menu with the
Button group
Feature branch env
Feature Branch Link