Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Button group component #12057

Merged
merged 15 commits into from
Oct 27, 2023
Merged

New Button group component #12057

merged 15 commits into from
Oct 27, 2023

Conversation

deanhannigan
Copy link
Contributor

@deanhannigan deanhannigan commented Oct 13, 2023

Description

Added a new Button group component to the Basic component section in the builder.

  • Dynamically add and remove buttons via the list.
  • Drag-and-drop button ordering.
  • Fine-grain configuration of each button via the button settings modal.
  • Customize the layout and flow of the buttons within their own dedicated container.

Addresses:

  • BUDI-7538

Screenshots

The Button group and its default buttons.

Screenshot 2023-10-13 at 16 02 37

When you click on the Cog icon you can fully configure the buttons as you would expect with the Button config modal. Click and hold on the entry on the list to rearrange the button order.

Screenshot 2023-10-13 at 15 50 05

Building a menu with the Button group

buttongroup

Feature branch env

Feature Branch Link

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #12057 (c06ee74) into master (54daf2f) will decrease coverage by 0.02%.
Report is 14768 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head c06ee74 differs from pull request most recent head ddda57f. Consider uploading reports for the commit ddda57f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #12057      +/-   ##
==========================================
- Coverage   74.39%   74.37%   -0.02%     
==========================================
  Files         326      326              
  Lines       13939    13941       +2     
  Branches     2937     2937              
==========================================
- Hits        10370    10369       -1     
- Misses       3328     3331       +3     
  Partials      241      241              
Files Coverage Δ
...es/server/src/integrations/tests/utils/postgres.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deanhannigan deanhannigan marked this pull request as ready for review October 16, 2023 08:08
@deanhannigan deanhannigan added the do not merge PR is not ready to be merged - generally the PR description should say why label Oct 16, 2023
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a few comments to explain the changes I've just made and pushed up, as we discussed.

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shogunpurple shogunpurple force-pushed the feature/buttongroup-component branch from c06ee74 to ddda57f Compare October 17, 2023 09:56
@shogunpurple shogunpurple deleted the feature/buttongroup-component branch October 17, 2023 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@mike12345567 mike12345567 restored the feature/buttongroup-component branch October 17, 2023 13:08
@mike12345567 mike12345567 reopened this Oct 17, 2023
@Budibase Budibase deleted a comment from github-actions bot Oct 17, 2023
@deanhannigan deanhannigan removed the do not merge PR is not ready to be merged - generally the PR description should say why label Oct 19, 2023
@MihailHadzhiev2022
Copy link
Contributor

LGTM

@deanhannigan deanhannigan merged commit 55a5408 into master Oct 27, 2023
10 checks passed
@deanhannigan deanhannigan deleted the feature/buttongroup-component branch October 27, 2023 08:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants