Ban user column to be used as display column #12003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike12345567
reviewed
Oct 9, 2023
| const subtype = fieldSchema.subtype as FieldSubtype | ||
| switch (subtype) { | ||
| case FieldSubtype.USER: | ||
| const related = await processOutputBBReferences( |
There was a problem hiding this comment.
One thing to consider here is performance if we have a lot of rows/links, this is inside a double loop, this await could massively delay things - I wonder if there is a better way we can manage this (like bulking the requests in someway?)
There was a problem hiding this comment.
As discussed, simplified to use a formula if required
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## feature/multi-user-type-column #12003 +/- ##
===================================================================
+ Coverage 56.44% 74.53% +18.09%
===================================================================
Files 259 326 +67
Lines 7916 13859 +5943
Branches 1471 2905 +1434
===================================================================
+ Hits 4468 10330 +5862
- Misses 3162 3293 +131
+ Partials 286 236 -50
... and 584 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adrinr
force-pushed
the
fix/use-user-table-as-display-column
branch
from
cec5ebd to
07b8218
Compare
adrinr
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabling user columns to be set as a display column. They add plenty of complexity, and there are workarounds using formulas instead
Screenshots