Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi user column #11988

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Oct 6, 2023

Description

Rethinking and reenabling multi-user column. This column was changed from being stored as a CSV to being an array, allowing complex filtering operations.

Addresses:

Screenshots

Filtering by user (single column)

image

Filtering by users (multiple column)

image

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #11988 (9f27362) into master (f8759a4) will increase coverage by 1.41%.
The diff coverage is 90.47%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #11988      +/-   ##
==========================================
+ Coverage   66.54%   67.95%   +1.41%     
==========================================
  Files         490      585      +95     
  Lines       19597    21768    +2171     
  Branches     4049     4373     +324     
==========================================
+ Hits        13040    14793    +1753     
- Misses       6061     6453     +392     
- Partials      496      522      +26     
Files Coverage Δ
...src/utilities/rowProcessor/bbReferenceProcessor.ts 89.36% <100.00%> (+0.72%) ⬆️
packages/server/src/integrations/base/sqlTable.ts 74.04% <85.71%> (+0.93%) ⬆️

... and 97 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr changed the base branch from feat/budi-7589-multi-user-column to develop October 6, 2023 10:33
@adrinr adrinr changed the base branch from develop to master October 6, 2023 10:33
@adrinr adrinr marked this pull request as ready for review October 6, 2023 10:35
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, some nice typing improvements as well!

@adrinr adrinr changed the base branch from master to feature/multi-user-type-column October 9, 2023 09:52
@adrinr adrinr merged commit b47ebd9 into feature/multi-user-type-column Oct 9, 2023
@adrinr adrinr deleted the budi-7589/user-column-multi-user-filtering-support branch October 9, 2023 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants