Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Portal License Key - Activate & Manage Tests #11980

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

Mitch-Budibase
Copy link
Contributor

@Mitch-Budibase Mitch-Budibase commented Oct 5, 2023

Description

There are two test files - license.activate.spec.ts and license.manage.spec.ts

These test files each contain a test:

  • Creates, activates, and deletes an online license for a self hosted account - license.activate.spec.ts
  • Retrieves plans, creates checkout session, and updates license - license.manage.spec.ts - WIP

Updated and created API files:

  • StripeAPI
  • LicenseAPI
  • internal-api LicenseAPI
  • index & AccountInternalAPI also updated to reflect API file changes

The license key manage test is a work in progress. The missing piece is 'Mimic checkout success' for Stripe. It is a requirement to create a customer using the Stripe SDK to finish this test

Feature branch env

Feature Branch Link

There are two test files, license.activate.spec.ts and license.manage.spec.ts

These test files each contain a test:
- Creates, activates, and deletes an online license for a self hosted account - license.activate.spec.ts
- Retrieves plans, creates checkout session, and updates license - license.manage.spec.ts

Updated and created API files
- StripeAPI
- LicenseAPI
- internal-api LicenseAPI
- index & AccountInternalAPI also updated to reflect API file changes
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few comments

I have removed the end of the test which was to 'Verify user downgraded to free license'
- This is not needed

I have also updated getLicenseKey - specifically how it handles the expected 200 response
@github-actions github-actions bot added the stale label Oct 13, 2023
@shogunpurple shogunpurple force-pushed the account-portal-api-license-key branch from a66ded8 to f3234f6 Compare October 17, 2023 09:56
@github-actions
Copy link
Contributor

CLA Assistant Lite bot:

Thank you for your submission - we really appreciate it ❤️. Like many open-source projects, we ask that you all sign a Contributor License Agreement before we can accept your contribution.

You can sign the CLA by just posting a Pull Request Comment, the same as the text below.

If you are contributing on behalf of a company, your company should contact us to sign a Corporate Contributor License Agreement, via [email protected].


I have read the CLA Document and I hereby sign the CLA


8 out of 9 committers have signed the CLA.
@aptkingston
@melohagan
@adrinr
@shogunpurple
@PClmnt
@mike12345567
@Ghrehh
@Samuel-Martineau
@Budibase Staging Release Bot
Budibase Staging Release Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@shogunpurple shogunpurple deleted the account-portal-api-license-key branch October 17, 2023 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@mike12345567 mike12345567 restored the account-portal-api-license-key branch October 17, 2023 13:10
@mike12345567 mike12345567 reopened this Oct 17, 2023
@mike12345567 mike12345567 changed the base branch from develop to master October 17, 2023 13:10
mike12345567 and others added 3 commits October 17, 2023 14:11
Update package.json
- Updating "test:self:ci"
- Now includes license. Needed to prevent license tests from running where an account portal is not setup

Removing license.manage.spec.ts
- This will be included in another PR
- Work required to finish this test
- Removing so the license activation test can be merged
@Mitch-Budibase Mitch-Budibase merged commit 2062d34 into master Oct 24, 2023
@Mitch-Budibase Mitch-Budibase deleted the account-portal-api-license-key branch October 24, 2023 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants