-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Portal License Key - Activate & Manage Tests #11980
Conversation
There are two test files, license.activate.spec.ts and license.manage.spec.ts These test files each contain a test: - Creates, activates, and deletes an online license for a self hosted account - license.activate.spec.ts - Retrieves plans, creates checkout session, and updates license - license.manage.spec.ts Updated and created API files - StripeAPI - LicenseAPI - internal-api LicenseAPI - index & AccountInternalAPI also updated to reflect API file changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few comments
I have removed the end of the test which was to 'Verify user downgraded to free license' - This is not needed I have also updated getLicenseKey - specifically how it handles the expected 200 response
a66ded8
to
f3234f6
Compare
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 8 out of 9 committers have signed the CLA. |
Update package.json - Updating "test:self:ci" - Now includes license. Needed to prevent license tests from running where an account portal is not setup Removing license.manage.spec.ts - This will be included in another PR - Work required to finish this test - Removing so the license activation test can be merged
Description
There are two test files - license.activate.spec.ts and license.manage.spec.ts
These test files each contain a test:
Updated and created API files:
The license key manage test is a work in progress. The missing piece is 'Mimic checkout success' for Stripe. It is a requirement to create a customer using the Stripe SDK to finish this test
Feature branch env
Feature Branch Link