Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for to ensure selectedBy Avatar is not obscured in NavItem #11889

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

deanhannigan
Copy link
Contributor

Description

If a source name was too long it would push the selectedBy Avatar out of view.

  • Source names should now truncate with an ellipsis if too long for the NavItem to display.
  • Hover text has been added to ensure users can still see the entire resource title
  • The Avatar should always remain in view

Screenshots

Screenshot 2023-09-26 at 10 48 39

…ed by Avatar was being pushed out of view. Hover text added
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #11889 (9b4201f) into master (762581f) will increase coverage by 0.06%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Current head 9b4201f differs from pull request most recent head 56c3cb0. Consider uploading reports for the commit 56c3cb0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #11889      +/-   ##
==========================================
+ Coverage   67.87%   67.94%   +0.06%     
==========================================
  Files         585      585              
  Lines       21858    21755     -103     
  Branches     4406     4366      -40     
==========================================
- Hits        14836    14781      -55     
+ Misses       6495     6452      -43     
+ Partials      527      522       -5     

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deanhannigan deanhannigan marked this pull request as ready for review September 26, 2023 10:15
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the stale label Oct 3, 2023
@github-actions github-actions bot closed this Oct 10, 2023
@deanhannigan deanhannigan reopened this Oct 11, 2023
@github-actions github-actions bot removed the stale label Oct 11, 2023
@aptkingston aptkingston enabled auto-merge October 12, 2023 07:28
@aptkingston aptkingston merged commit 80417b9 into master Oct 12, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants