Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Added] Creators quota update #11799

Merged
merged 10,000 commits into from
Oct 17, 2023
Merged

[Added] Creators quota update #11799

merged 10,000 commits into from
Oct 17, 2023

Conversation

jvcalderon
Copy link
Contributor

@jvcalderon jvcalderon commented Sep 18, 2023

Description

Depends on: https://github.com/Budibase/budibase-pro/pull/222

Changes needed to deal with creators tracking.

Addresses:
https://linear.app/budibase/issue/GROW-43/track-creators

Screenshots

Screen.Recording.2023-09-18.at.13.26.58.mov

Documentation

  • I have reviewed the budibase documentatation to verify if this feature requires any changes. If changes or new docs are required I have written them.

@jvcalderon jvcalderon added the backend Involves some work on the backend label Sep 18, 2023
@jvcalderon jvcalderon self-assigned this Sep 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #11799 (b3d899c) into develop (309f829) will increase coverage by 0.00%.
The diff coverage is 88.88%.

❗ Current head b3d899c differs from pull request most recent head 0e95b45. Consider uploading reports for the commit 0e95b45 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff            @@
##           develop   #11799   +/-   ##
========================================
  Coverage    74.38%   74.39%           
========================================
  Files          326      327    +1     
  Lines        13941    13950    +9     
  Branches      2937     2937           
========================================
+ Hits         10370    10378    +8     
- Misses        3330     3331    +1     
  Partials       241      241           
Files Coverage Δ
...c/migrations/functions/usageQuotas/syncCreators.ts 100.00% <100.00%> (ø)
...ages/server/src/migrations/functions/syncQuotas.ts 53.84% <50.00%> (-0.70%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot closed this Oct 12, 2023
@jvcalderon jvcalderon reopened this Oct 12, 2023
@github-actions github-actions bot removed the stale label Oct 12, 2023
@jvcalderon
Copy link
Contributor Author

We need to apply the migration in prod: https://budibase.atlassian.net/wiki/spaces/EN/pages/9896119/Migrations

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

CLA Assistant Lite bot:

Thank you for your submission - we really appreciate it ❤️. Like many open-source projects, we ask that you all sign a Contributor License Agreement before we can accept your contribution.

You can sign the CLA by just posting a Pull Request Comment, the same as the text below.

If you are contributing on behalf of a company, your company should contact us to sign a Corporate Contributor License Agreement, via [email protected].


I have read the CLA Document and I hereby sign the CLA


6 out of 7 committers have signed the CLA.
@mike12345567
@adrinr
@melohagan
@jvcalderon
@shogunpurple
@aptkingston
@Budibase Staging Release Bot
Budibase Staging Release Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@jvcalderon jvcalderon force-pushed the feature/creators-count branch from b12ebb6 to fce3380 Compare October 16, 2023 08:01
@shogunpurple shogunpurple force-pushed the feature/creators-count branch from a99c20a to 53219a6 Compare October 17, 2023 09:59
@jvcalderon jvcalderon added the migrations Involves a data migration using the BB data migration document system. label Oct 17, 2023
@jvcalderon jvcalderon merged commit abb8f78 into develop Oct 17, 2023
@jvcalderon jvcalderon deleted the feature/creators-count branch October 17, 2023 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Involves some work on the backend migrations Involves a data migration using the BB data migration document system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants