Merge pull request #15136 from Budibase/fix-multi-checkbox-value-coer…

…cion Stop coercing all values to strings when using CoreCheckboxGroup
Budibase · Dec 10, 2024 · a3c1bbc · a3c1bbc
2 parents a5f5f39 + 5a093da
commit a3c1bbc
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/bbui/src/Form/Core/CheckboxGroup.svelte b/packages/bbui/src/Form/Core/CheckboxGroup.svelte
@@ -13,9 +13,8 @@
 
   const dispatch = createEventDispatcher()
 
-  const onChange = e => {
-    const optionValue = e.target.value
-    if (e.target.checked && !value.includes(optionValue)) {
+  const onChange = optionValue => {
+    if (!value.includes(optionValue)) {
       dispatch("change", [...value, optionValue])
     } else {
       dispatch(
@@ -39,10 +38,9 @@
           class="spectrum-Checkbox spectrum-Checkbox--sizeM spectrum-FieldGroup-item"
         >
           <input
-            on:change={onChange}
+            on:change={() => onChange(optionValue)}
             type="checkbox"
             class="spectrum-Checkbox-input"
-            value={optionValue}
             checked={value.includes(optionValue)}
             {disabled}
           />