Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullsoft installers (or MSI) + winget #135

Closed
DanTheMan827 opened this issue Mar 10, 2022 · 6 comments
Closed

Nullsoft installers (or MSI) + winget #135

DanTheMan827 opened this issue Mar 10, 2022 · 6 comments

Comments

@DanTheMan827
Copy link

DanTheMan827 commented Mar 10, 2022

It would be very convenient if this could be packaged inside an installer and automatically submitted to the winget package repository at microsoft/winget-pkgs

I've found this post detailing how you can automatically submit to winget https://www.dolthub.com/blog/2021-10-13-how-to-publish-winget-chocolatey-packages-with-github-actions/

@BtbN
Copy link
Owner

BtbN commented Mar 10, 2022

I don't really see how this could be sensibly put into an installer.
Windows has no standard paths or anything to put stuff into.

@garoto
Copy link

garoto commented Mar 10, 2022

Just drop everything into C:\Windows and it should be fine.

@DanTheMan827
Copy link
Author

DanTheMan827 commented Mar 12, 2022 via email

@BtbN
Copy link
Owner

BtbN commented Mar 24, 2022

I don't think an installer is a good idea as it gives the wrong idea to users about there being any sort of official location/build/path for ffmpeg.

@BtbN BtbN closed this as completed Mar 24, 2022
@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Aug 5, 2022

@DanTheMan827 and @garoto, most users are hesitant or unable to perform those operations, and @BtbN, standard paths for installation definitely exist: these are usually "file:///%SystemDrive%/Program%20Files" and, for user-specific files, %AppData%.

I am unable to ascertain why the mere presence of the installer would demonstrate somehow that this is official, as is purported. If such designation is undesirable, I suggest that this location be removed from "https://ffmpeg.org/download.html#build-windows#:~:text=ready%20to%20go.-,windows%20exe%20files,-Windows%20builds%20from". The lack of an installer merely causes this to be unnecessarily difficult to install.

@DanTheMan827
Copy link
Author

DanTheMan827 commented Aug 8, 2022

@BEEDELLROKEJULIANLOCKHART @BtbN I wasn't suggesting anything because it was "official", but merely because winget as a package manager just makes it easier for people to re-install software after a format or just keep it up to date.

There's a couple projects with multiple variants in winget maintained by different teams and they're just differentiated by their designation.

BtbN.FFmpeg would be the one for this project if there were installers available, but that wouldn't make it the official ffmpeg, just this build of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants