Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow visibility of builders to differ from the underlying constructor #70

Closed
BrynCooke opened this issue Jul 31, 2022 · 1 comment · Fixed by #71
Closed

Allow visibility of builders to differ from the underlying constructor #70

BrynCooke opened this issue Jul 31, 2022 · 1 comment · Fixed by #71

Comments

@BrynCooke
Copy link
Owner

So that an API can be purely builder based.
Allow some sort of override for the generated builder module.
@BrynCooke BrynCooke linked a pull request Jul 31, 2022 that will close this issue
Add the ability to override builder visibility. #71
Merged
@BrynCooke
Copy link
Owner Author

BrynCooke commented Jul 31, 2022 •
edited
Loading

Use:
#[builder(visibility = "pub")]

Valid values are:

  • pub
  • pub (crate)

To make your API builder only based make your constructor private and add a public builder.

SimonSapin added a commit to apollographql/router that referenced this issue Aug 9, 2022
@SimonSapin
Make constructors private when there’s a public builder
b11f238 
This uses BrynCooke/buildstructor#70
SimonSapin added a commit to apollographql/router that referenced this issue Aug 12, 2022
@SimonSapin
Make constructors private when there’s a public builder
9e9c96a 
This uses BrynCooke/buildstructor#70
SimonSapin added a commit to apollographql/router that referenced this issue Aug 12, 2022
@SimonSapin
Make constructors private when there’s a public builder
3b6e22a 
This uses BrynCooke/buildstructor#70
SimonSapin added a commit to apollographql/router that referenced this issue Aug 12, 2022
@SimonSapin
Make constructors private when there’s a public builder
a66a665 
This uses BrynCooke/buildstructor#70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the ability to override builder visibility. BrynCooke/buildstructor
1 participant
@BrynCooke