Skip to content

Commit

Permalink
View-transitions should only be allowed when page is visible
Browse files Browse the repository at this point in the history
- Skip the transition if document becomes hidden
- Disallow oubound cross-document view transitions when document is
  hidden
- Skip inbound cross-document view transition if document becomes
  hidden
- When calling startViewTransition() in a hidden document, start is
  as skipped.

Based on following CSS resolution:
w3c/csswg-drafts#9543 (comment)

Bug: 329302331
Change-Id: Ieef3238240b35c5d7f7f819793f65f71d7d75037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374309
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1273445}
  • Loading branch information
noamr authored and BruceDai committed Mar 25, 2024
1 parent 6e5bcea commit 0110763
Showing 1 changed file with 71 additions and 0 deletions.
71 changes: 71 additions & 0 deletions css/css-view-transitions/transition-in-hidden-page.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
<!DOCTYPE html>
<title>View transitions: Transition in a hidden page</title>
<link rel="help" href="https://drafts.csswg.org/css-view-transitions-1/">
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/page-visibility/resources/window_state_context.js"></script>
<style>
::view-transition-group(*) {
animation-duration: 5s;
}
</style>
<script>
promise_test(async t => {
assert_implements(document.startViewTransition, "Missing document.startViewTransition");

const wsc = window_state_context(t);
await wsc.minimize();
assert_true(document.hidden);
const transition = document.startViewTransition();
await wsc.restore();
const [readyResult] = await Promise.allSettled([transition.ready]);
assert_equals(readyResult.status, "rejected");
}, "A view transition should be immediately skipped if started when document is hidden");

promise_test(async t => {
assert_implements(document.startViewTransition, "Missing document.startViewTransition");

const wsc = window_state_context(t);
const transition = document.startViewTransition(async () => {
await wsc.minimize();
});

let event_fired = false;

window.addEventListener("visibilitychange", () => {
if (document.hidden)
event_fired = true;
});

// Restoring so that the document has an opportunity to present the real
// frame and start the transition's animation.
await wsc.restore();

const [readyResult] = await Promise.allSettled([transition.ready]);
assert_true(event_fired, "visibilitychange event should fire before skipping the transition");
await transition.finished;
assert_equals(readyResult.status, "rejected");
}, "A view transition should be skipped when a document becomes hidden while processing update callback");

promise_test(async t => {
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
assert_false(document.hidden);
const wsc = window_state_context(t);
const transition = document.startViewTransition(() => { });
await transition.ready;
await new Promise(resolve => requestAnimationFrame(resolve));
await wsc.minimize();
const result = await new Promise(resolve => {
transition.finished.then(() => resolve("finished"));
t.step_timeout(() => resolve("timeout"), 1000);
});

assert_equals(result, "finished");
}, "A view transition should be skipped when a document becomes hidden while animating");
</script>
</body>

</html>

0 comments on commit 0110763

Please sign in to comment.