Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enable Stylo by default #511

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Don't enable Stylo by default #511

merged 2 commits into from
Apr 10, 2018

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Apr 6, 2018

Stylo from Firefox 56 is affected by many Web compatibility and security issues. It also crashes and degrades performance in some situations. Let's disable it at runtime but keep layout.css.servo.enabled usable for experienced users.

@MrAlex94
Copy link
Collaborator

MrAlex94 commented Apr 6, 2018 via email

@jbeich
Copy link
Contributor Author

jbeich commented Apr 8, 2018

A better option is to simply drop --enable-stylo by relying on Firefox 56 default:
https://github.com/MrAlex94/Waterfox/blob/67d2b0ee4c226f7d5c45093bed9b3c3832178b08/toolkit/moz.configure#L601-L611

@Mikhail-M12
Copy link

I have found that layout.css.servo.enabled=true breaks zooming with "Zoom Text Only" enabled.

@MrAlex94 MrAlex94 merged commit ec4c215 into BrowserWorks:master Apr 10, 2018
@MrAlex94
Copy link
Collaborator

Fixed a conflict and merged. Cheers 👍

@jbeich jbeich deleted the stylo-only-build branch April 15, 2018 05:38
@decembre
Copy link

It seems broke Firebug too:
[SOLVED] Editing CSS with Waterfox 56.01+ firebug : new bug ??? [Solution = Disable Stylo]
"When i edit an userstyle and preview the effect with firebug open , firebug stop to show my CSS code in the htlm panel.
If i reload the page , it show it.
"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants