[WFX-375] Remove blank space before private tab menuitems. #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlex94
force-pushed
the
current
branch
3 times, most recently
from
8633d6f to
e32197e
Compare
|
@adamp01, sorry had to rebase for the fixes yesterday. |
adamp01
force-pushed
the
priv
branch
2 times, most recently
from
83cef68 to
26d2c62
Compare
This was referenced Apr 11, 2022
|
Need to update Lepton once black7375/Firefox-UI-Fix#357 merged. |
|
Wording updated to "Make Private Tab", "Exit Private Tab" |
|
@davidmaxwaterman - should be good to merge |
MrAlex94
approved these changes
Apr 12, 2022
MrAlex94
pushed a commit
that referenced
this pull request
May 3, 2022
MrAlex94
pushed a commit
that referenced
this pull request
May 26, 2022
MrAlex94
pushed a commit
that referenced
this pull request
Jun 23, 2022
MrAlex94
pushed a commit
that referenced
this pull request
Jul 28, 2022
MrAlex94
pushed a commit
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily to remove the indentation before private tab menuitem's in context menu's. This will be most notable on Firefox default themes on Windows. It will also no longer add a check mark to the tab context menu "Private Tab" menuitem. Instead it will change the wording from "Make Private Tab" to "End Private Mode" depending on the current tabs usercontextid (container). Really need to think about the wording though.
Check mark pushes all items to the side:
menuitem-iconicclass creates additional space on Windows: