Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable or Provide Our Own Captive Portal Detection #681

Closed
ilikenwf opened this issue Jun 27, 2018 · 15 comments
Closed

Disable or Provide Our Own Captive Portal Detection #681

ilikenwf opened this issue Jun 27, 2018 · 15 comments

Comments

@ilikenwf
Copy link

Because we know that Mozilla isn't super trustworthy for privacy (in terms of marketing, logging, etc), it would be nice to either disable or replace with our own the captive portal dection system. I'm fairly certain it pings detectportal.firefox.com on every network we connect to.

It reminds me of the generate_204 pages that Chrome/Chromium and Android use. While no data is shared, usually, metadata and IP address info is there, and enough for corellation of users.

@ilikenwf
Copy link
Author

...and while I do use a Firefox sync account, I do take issue with unnecessarily phoning home like this.

@WagnerGMD
Copy link

WagnerGMD commented Jun 28, 2018

pref("network.captive-portal-service.enabled",false);
In the meanwhile, you can open the page about:config to disable it.

PS : Only this one ? Yes I believe and the word key is : "portal".
As reminder, no I don't have a huge knowledge on this matter but now you can search and check it (over the internet).
Because according to my memories, it was already mentioned (a few times) here on the Waterfox GitHub a long time ago.

@grahamperrin
Copy link

I shouldn't default to disabling the feature.

I've seen too many situations where users are confused in portal situations. Guidance, resulting from detection, is more user-friendly.

… already mentioned …

detectportal.firefox.com is mentioned in:

@ilikenwf
Copy link
Author

If there were a success.txt file or just a HTTP 204 generator on the waterfox site, this could be kept with a more privacy friendly url.

@ghost
Copy link

ghost commented Jun 29, 2018

For firefox, I just remove the URL and set it to 'false'.
For Tor Browser, it's disabled by default.

If Waterfox is for power users, why not add a checkbox: "Disable Portal detection"

@ghost
Copy link

ghost commented Jun 29, 2018

more privacy friendly url

IMHO Waterfox webpage is behind Cloudflare, that's really privacy unfriendly.
See https://trac.torproject.org/projects/tor/ticket/24351

@grahamperrin
Copy link

Please, let's keep this focused – captive portal detection.

Cloudflare discussions include:

@Atavic
Copy link

Atavic commented Jan 2, 2019

If you use sync, then phoning home will definitely happen. I do consider it unnecessary, but - by looging into sync - you just agreed to Mozilla way of using its services. Reconsider the use of sync, IMHO.

@ilikenwf
Copy link
Author

ilikenwf commented Jan 2, 2019 via email

@Atavic
Copy link

Atavic commented Jan 2, 2019

I have setup my own sync server

So my previous comment doesn't apply anymore, I agree with your concerns.

@mparnelldmp
Copy link

Things like this are why I think librefox, be it in stock firefox or in waterfox, seems like a great idea.

@grahamperrin
Copy link

@mparnelldmp please, what problem do you find with the existing detection routine?

@mparnelldmp
Copy link

I don't think having it enabled by default is a good idea, the same goes for any other part of WF that reaches out and touches a remote server, except for maybe the WF updates server (which doesn't apply for distro packages).

@grahamperrin
Copy link

I don't think having it enabled by default is a good idea, …

Why not?

… any other part of WF …

Please, let's keep this focused; captive portal detection.

@mparnelldmp
Copy link

I reported to Mozilla but, because it uses http, it's trivially easy to use MiTM to hijack these requests by faking the gateway on any given network and then redirect or replace the content with whatever nastiness the attacker desires, because it appears to be an "official" browser function since a little thing drops down and tells you to click here to login to the network...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants