Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing css, component and dependency changes to production #97

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

Rikveet
Copy link
Collaborator

@Rikveet Rikveet commented Nov 4, 2022

Changes 🛠

Name and title displayed over image.
Disc becomes visible/invisible onClick.
created team-exec-info component.
Moved exec info html to Team-exec-info component.
Update outdated dependencies and fixed webpack dependency error

What does this PR do?

This ^

Any new npm dependencies?

Yes, updated.

Testing 🧪

Changes from the latest PR are deployed to https://brockcsc-pr.web.app once the checks are complete. Can use this for testing.

Any other info neededed for testing?

NO

Rikveet and others added 3 commits November 4, 2022 17:57
Name and title displayed over image.
Disc becomes visible/invisible onClick.
created team-exec-info component.
Moved exec info html to Team-exec-info component.
fixing webpack dependency error and updating outdated dependencies.
@Rikveet Rikveet requested review from kindeep and Joel-Liju November 4, 2022 23:02
@Joel-Liju
Copy link
Collaborator

LGTM

@Joel-Liju Joel-Liju merged commit e965ed0 into production Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants