Improve the settings interface and update extension dependencies #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 2, 2021 18:15
* The "type" field is ignored by VSCode on the root configuration object * The title should match the exact name of the extension, omitting words like "configuration"
The "vscode" package is deprecated in favor of "@types/vscode" and "vscode-test". Since no actual tests were written for this package, the tests are deleted and the "vscode-test" dependency was omitted. The "postinstall" script is no longer required.
|
First, thank you for your contribution. Give me a few days to look at this pull request. |
|
Sorry for the delay, still need more time, but did not forget about this. |
|
Sorry again, I am going to dedicate some time this week to merge this one. Again, thanks for this great work. |
|
published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
contributes.configurationtitleattributetypefieldstring, opting into better settings UIscopetolanguage-overridable(fixes Unknown editor configuration setting "togglequotes.chars" #10)Also uninstalls the deprecated
vscodepackage in favor of@types/vscode. Thepostinstallstep is no longer needed. There were no actual tests of this extension, so I deleted the outdated test example files.The implementation of
getConfigurationwas updated to use the document scope, so language overrides are handled by VSCode instead of the old custom implementation.