Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore escaped quotes #4

Open
jeremychone opened this issue Feb 9, 2018 · 1 comment
Open

Ignore escaped quotes #4

jeremychone opened this issue Feb 9, 2018 · 1 comment
Milestone
0.3.0

Comments

@jeremychone
Copy link
Contributor

jeremychone commented Feb 9, 2018 •
edited
Loading

Problem

Today, if the cursor ][ is after or before, the escaped quote will be accounted a quote to toggle (and it should not).

"Hello I\'m][ hungry"

Solution

Ignore the escaped single or double quotes when determining which quote pair should be toggled.
@jeremychone jeremychone mentioned this issue Feb 9, 2018
Closed
@jeremychone jeremychone changed the title Ignored escape quotes Ignore escaped quotes Apr 5, 2018
@jeremychone jeremychone added this to the 0.3.0 milestone Apr 5, 2018
jeremychone added a commit that referenced this issue Apr 5, 2018
@jeremychone
.#4 Ignore escaped quotes
cd1e1d5
@ghost
Copy link

ghost commented May 3, 2021

This is solved in PR #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@jeremychone