Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEX-3361 - check if registerRoutes options is defined #51

Merged
merged 2 commits into from
Dec 10, 2024
Merged

NEX-3361 - check if registerRoutes options is defined #51

merged 2 commits into from
Dec 10, 2024

Conversation

lweber-d2l
Copy link
Contributor

NEX-3361 - [Maintenance] Investigate test failures: D2L Link UI not loading

Context:

D2L Link test automation started failing the morning of Dec 10. An update to @brightspace-ui-labs/lit-router was released Dec 9.

image

Fix:

Add check for defined. Issue the warning in either case: options is not defined, or options is defined but enableRouteOrderFix is not.

@lweber-d2l lweber-d2l self-assigned this Dec 10, 2024
@lweber-d2l lweber-d2l marked this pull request as ready for review December 10, 2024 14:41
@lweber-d2l lweber-d2l requested a review from a team as a code owner December 10, 2024 14:41
dlockhart
dlockhart reviewed Dec 10, 2024
View reviewed changes
router.js Outdated Show resolved Hide resolved
jorge-ramirez-arredondo
jorge-ramirez-arredondo approved these changes Dec 10, 2024
View reviewed changes
router.js Outdated Show resolved Hide resolved
@lweber-d2l @dlockhart
Update router.js
1ef2d75 
Use more compact optional chaining notation.

Co-authored-by: Dave Lockhart <[email protected]>
dlockhart
dlockhart approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Make sure you put fix: <whatever> in the merge commit so that it triggers a release.

@dlockhart dlockhart merged commit 88157e3 into main Dec 10, 2024
1 check passed
@dlockhart dlockhart deleted the lweber/nex-3361-check-options-defined branch December 10, 2024 15:18
@d2l-github-release-tokens D2L GitHub Release Tokens
Copy link

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lweber-d2l
Copy link
Contributor Author

Thanks for the fix! Make sure you put fix: <whatever> in the merge commit so that it triggers a release.

Thanks for the review & release. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorge-ramirez-arredondo jorge-ramirez-arredondo jorge-ramirez-arredondo approved these changes

@dlockhart dlockhart dlockhart approved these changes

Assignees

@lweber-d2l lweber-d2l

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lweber-d2l @dlockhart @jorge-ramirez-arredondo