Merge pull request #13 from BrightspaceUI/cbusman/d2l-navigation-butt…

…on_height_style Adding height CSS by default to buttons and links.
BrightspaceUILabs · Oct 15, 2018 · 2bdbf66 · 2bdbf66
2 parents 2675c38 + 34821d3
commit 2bdbf66
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 2 deletions.
diff --git a/d2l-navigation-button-close.html b/d2l-navigation-button-close.html
@@ -19,6 +19,7 @@
 		<style>
 			:host {
 				display: inline-block;
+				height: 100%;
 			}
 			d2l-navigation-button-notification-icon {
 				height: 100%;

diff --git a/d2l-navigation-button-notification-icon.html b/d2l-navigation-button-notification-icon.html
@@ -19,6 +19,7 @@
 		<style>
 			:host {
 				display: inline-block;
+				height: 100%;
 			}
 			:host([notification]) .d2l-navigation-button-notification-indicator {
 				display: inline-block;

diff --git a/d2l-navigation-link-back.html b/d2l-navigation-link-back.html
@@ -18,6 +18,7 @@
 		<style>
 			:host {
 				display: inline-block;
+				height: 100%;
 			}
 			d2l-icon {
 				color: inherit;

diff --git a/d2l-navigation-link-image.html b/d2l-navigation-link-image.html
@@ -13,6 +13,7 @@
 		<style>
 			:host {
 				display: inline-block;
+				height: 100%;
 			}
 			img {
 				vertical-align: middle;

diff --git a/demo/d2l-navigation-button.html b/demo/d2l-navigation-button.html
@@ -94,11 +94,13 @@ <h3>d2l-navigation-button</h3>
 			<demo-snippet>
 				<template>
 					<style>
+						.button-holder {
+							height: 90px;
+						}
 						d2l-navigation-button-notification-icon,
 						d2l-navigation-button-image,
 						d2l-navigation-button-close {
 							margin: 0px 5px;
-							height: 90px;
 						}
 					</style>
 					<d2l-navigation-band></d2l-navigation-band>
@@ -119,10 +121,12 @@ <h3>d2l-navigation-link</h3>
 			<demo-snippet>
 				<template>
 					<style>
+						.button-holder {
+							height: 90px;
+						}
 						d2l-navigation-link-back,
 						d2l-navigation-link-image {
 							margin: 0px 5px;
-							height: 90px;
 						}
 					</style>
 					<d2l-navigation-band></d2l-navigation-band>