feat: add test reporting to component generation #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devpow112
changed the title
devpow112
force-pushed
the
depowell/test-reporting
branch
2 times, most recently
from
760cab1 to
5fe2e0e
Compare
devpow112
commented
Jul 30, 2024
| @@ -1,7 +1,7 @@ | |||
| import '../<%= hyphenatedName %>.js'; | |||
| import { expect, fixture, html } from '@brightspace-ui/testing'; | |||
|
|
|||
| describe('<%= className %>', () => { | |||
| describe('<%= tagName %>', () => { | |||
There was a problem hiding this comment.
This didn't match what we tend to do in the wild and also didn't match our vdiff suite names. Changing to be all the same
devpow112
commented
Jul 30, 2024
| @@ -1,7 +1,7 @@ | |||
| import '../<%= hyphenatedName %>.js'; | |||
| import { runConstructor } from '@brightspace-ui/testing'; | |||
|
|
|||
| describe('<%= className %>', () => { | |||
| describe('<%= tagName %>', () => { | |||
There was a problem hiding this comment.
This didn't match what we tend to do in the wild and also didn't match our vdiff suite names. Changing to be all the same
devpow112
force-pushed
the
depowell/test-reporting
branch
from
5fe2e0e to
3788c79
Compare
devpow112
force-pushed
the
depowell/test-reporting
branch
from
3788c79 to
90ed8b2
Compare
dlockhart
reviewed
Jul 30, 2024
Co-authored-by: Dave Lockhart <[email protected]>
dlockhart
approved these changes
Jul 30, 2024
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://desire2learn.atlassian.net/browse/QE-264
This adds the configuration pieces for test reporting and fixes a few other minor inconsistencies.