De20872 code review suggestion remove event listener #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| client.sendEvent('userIsActive'); | ||
| })); | ||
| document.addEventListener('keydown', throttle(function() { | ||
| var listener = throttle(function userActivityListener() { |
There was a problem hiding this comment.
You don't need the function names here (or in the removal below). So this could just be:
var listener = throttle(function() {
client.sendEvent('userIsActive');
});
There was a problem hiding this comment.
lack of need is definitely true - I added them for stack-tracey things, but either way :)
There was a problem hiding this comment.
So what's the consensus - leave function name for stack-tracey-purposes, or remove?
There was a problem hiding this comment.
I'm good either way as well, up to you Tyler!
There was a problem hiding this comment.
Ok, thanks. I'm good leaving the function names present. then. If we're satisfied, can you merge and version ifrau @dlockhart? Thanks :-)
tylergee
deleted the
DE20872_code_review_suggestion_remove_event_listener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.