Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Empty commit to trigger release #164

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

EvanLemieux
Copy link
Contributor

@EvanLemieux EvanLemieux commented Oct 11, 2023

Forgot to prepend my merge with feat:

@EvanLemieux EvanLemieux merged commit 0175cfb into master Oct 11, 2023
1 check passed
@EvanLemieux EvanLemieux deleted the elemieux/trigger-release branch October 11, 2023 20:14
@ghost
Copy link

ghost commented Oct 11, 2023

🎉 This PR is included in version 0.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Oct 11, 2023
@grant-cleary
Copy link
Contributor

So I think pushing this as a feat release just made things a bit tricky because ifrau is in pre-release. I think you'll now need to coordinate updating every dependency that uses it in BSI to upgrade at the same time, otherwise trying to bump it in BSI alone will blow up the BSI build. 😅

@EvanLemieux
Copy link
Contributor Author

So I think pushing this as a feat release just made things a bit tricky because ifrau is in pre-release. I think you'll now need to coordinate updating every dependency that uses it in BSI to upgrade at the same time, otherwise trying to bump it in BSI alone will blow up the BSI build. 😅

Oh shoot... I figured a patch wasn't the way to go since this changed the params for the function. I guess I'll be putting up a number of PRs now.

@grant-cleary
Copy link
Contributor

Oh shoot... I figured a patch wasn't the way to go since this changed the params for the function. I guess I'll be putting up a number of PRs now.

Yeah, I mean I think feat: is the most correct choice, but because ifrau is in pre-release, minor releases are treated as breaking changes, which ends up making life a bit more painful. 😞

@eKoopmans
Copy link

Or do a new hacky commit to do a patch after all... would probably work, but we might want to find a way to un-publish this minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants