upgrading to eslint 4 from 2 and improving how we extend configurations #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthjones Just saw your other PR to make this a peer dependency... which never got merged. Should we combine forces somehow? |
|
Haha, that PR is almost celebrating a birthday soon! 😀 I don't even remember the context of it anymore, and to my knowledge peer dependencies are deprecated in newer npm versions (and were widely considered a mistake), so it can probably just be closed. |
dbatiste
approved these changes
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dbatiste our existing configuration blows up if consumers try to use eslint 4, so figured it was time to upgrade this. Was also able to extend things a little easier using eslint's built-in "extend".