Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily add @unchecked Sendable to every mock. #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatyasKriz
Copy link
Collaborator

If you have mocks that make use of Sendable or otherwise use Swift concurrency, please try integrating this branch and voting with reactions whether everything works as expected.

@stzouvaras
Copy link

hello @MatyasKriz ,

this is a welcomed temporary solution but unfortunately, this is not enough we also need to adjust TypeErasureTemplate and NopImplStubTemplate

@MatyasKriz
Copy link
Collaborator Author

Thanks for letting me know, I'll see what I can do. 🙂

@MatyasKriz MatyasKriz added the awaiting response A Cuckoo maintainer is awaiting response from the issue/PR author/community. label Oct 9, 2024
@MatyasKriz
Copy link
Collaborator Author

Okay, the fix is pushed. I decided to remove the previous implementation, it was too fragile anyway. It's now just hardcoded in the templates you provided. @stzouvaras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response A Cuckoo maintainer is awaiting response from the issue/PR author/community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants