Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.InvalidCastException thrown when using UsePostgreSqlOutbox ServiceCollection Extension #1837

Conversation

samrumley88
Copy link
Contributor

@samrumley88 samrumley88 commented Nov 11, 2021

Pull request for #1820

  • Fix bug in UsePostgreSqlOutbox ServiceCollection extension regarding the DI registration of the IAmAnOutboxAsync interface.

  • Fix bugs in PostgreSql syntax for PostgreSqlOutboxSync.CreatePagedDispatchedCommand, PostgreSqlOutboxSync.CreatePagedOutstandingCommand and PostgreSqlOutboxSync.InitMarkDispatchedCommand.

…g the DI registration of the IAmAnOutboxAsync interface.

- Fix bugs in PostgreSql syntax for PostgreSqlOutboxSync.CreatePagedDispatchedCommand, PostgreSqlOutboxSync.CreatePagedOutstandingCommand and PostgreSqlOutboxSync.InitMarkDispatchedCommand.
@CLAassistant
Copy link

CLAassistant commented Nov 11, 2021

CLA assistant check
All committers have signed the CLA.

@samrumley88 samrumley88 changed the title System.InvalidCastException thrown when using UsePostgreSqlOutbox ServiceCollection Extension #1820 System.InvalidCastException thrown when using UsePostgreSqlOutbox ServiceCollection Extension Nov 11, 2021
@samrumley88 samrumley88 marked this pull request as ready for review November 11, 2021 17:04
Copy link
Member

@iancooper iancooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@DevJonny
Copy link
Contributor

Looks like the build is failing because of secrets not allowed in a forked branch PR?

@holytshirt
Copy link
Member

@DevJonny yeah, need to fix that and not push the packages

holytshirt and others added 5 commits November 14, 2021 23:18
…ter name combinations which have do not have the exact same casing. Npgsql 6.0 no longer matches in a case-insensitive manner. npgsql/npgsql#4027
…arameter name combinations which have do not have the exact same casing. Npgsql 6.0 no longer matches in a case-insensitive manner. npgsql/npgsql#4027
@DevJonny DevJonny merged commit 648f978 into BrighterCommand:master Nov 16, 2021
@samrumley88 samrumley88 deleted the issue/usepostgresqloutbox_exception branch November 16, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants