Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up of dispose and delays in Dispatcher and Dispatcher tests #1487

Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix: clean up of dispose and delays in Dispatcher and Dispatcher tests #1487

merged 1 commit into from
Apr 19, 2021

Conversation

holytshirt
Copy link
Member

  • On Start, wait until dispatcher is running before continuing
  • Remove delays from tests
  • Use more async-y tests

iancooper
iancooper approved these changes Apr 18, 2021
View reviewed changes
Copy link
Member

@iancooper iancooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up Toby

@iancooper iancooper merged commit 1f5dd64 into master Apr 19, 2021
@iancooper iancooper deleted the dispatchercleanup branch September 21, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iancooper iancooper iancooper approved these changes

@DevJonny DevJonny Awaiting requested review from DevJonny DevJonny is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holytshirt @iancooper