Added Configurable AckOnRead and Revved NuGet for ASB #1445 #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preardon
requested review from
DevJonny,
holytshirt and
iancooper
as code owners
|
|
iancooper
reviewed
Mar 20, 2021
src/Paramore.Brighter.MessagingGateway.AzureServiceBus/AzureServiceBusConsumer.cs
Outdated
Show resolved
Hide resolved
preardon
force-pushed
the
issue/1445-ConfigAckForASB
branch
from
cf38389
to
5baaa58
Compare
iancooper
approved these changes
Mar 20, 2021
|
@preardon Thanks for doing that. Going to merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureServiceBusConfiguration now contains AckOnRead to allow the switching from ReadAndDelete and Peek Lock
Acknowledge is still a NoOp if set to ReadAndDelete
Storing the Lock Token in the Message Bag in the Headers
Revved Nuget Microsoft.Azure.ServiceBus to 5.1.2, the Only Breaking Change in the Change log did not appear to effect us (SessionId Must be same as Partition key)