Fix message parse failed issue with AWS SQS #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original
…e can be parsed successfully when SNS message attributes are not present.
honkuan86
requested review from
DevJonny,
holytshirt and
iancooper
as code owners
|
|
|
Thanks for this @honkuan86 . I'll skip worrying about the failing CI tests because it looks environmental. This change makes sense as it follows our tolerant reader mantra of trying to make it work even if you don't send us everything we need. Can you sign the CLA? Then we are good to merge this |
Hi @iancooper , I have signed the CLA. Thanks. |
iancooper
approved these changes
Mar 20, 2021
|
@honkuan86 thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #1447 .
The changes is at SqsMessageCreator to default the HeaderResult.Success to true for all headers, so message can be parsed successfully when SNS message attributes are not present.