Ensure that SendAsync does not end a Span it didn't created (#3243)

BrighterCommand · Aug 7, 2024 · 3430d02 · 3430d02
1 parent bcf4a56
commit 3430d02
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Paramore.Brighter/CommandProcessor.cs b/src/Paramore.Brighter/CommandProcessor.cs
@@ -345,12 +345,14 @@ await handlerChain.First().HandleAsync(command, cancellationToken)
                 }
                 catch (Exception)
                 {
-                    span.span?.SetStatus(ActivityStatusCode.Error);
+                    if (span.created)
+                        span.span?.SetStatus(ActivityStatusCode.Error);
                     throw;
                 }
                 finally
                 {
-                    EndSpan(span.span);
+                    if (span.created)
+                        EndSpan(span.span);
                 }
             }
         }