Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling for when Annotated is inside another type; namely list[Annotated[...]]. #289

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

BrianPugh
Copy link
Owner

Addresses #287 .

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.83%. Comparing base (2b6c5ea) to head (765e723).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cyclopts/argument.py 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   93.84%   93.83%   -0.01%     
==========================================
  Files          26       26              
  Lines        3005     3019      +14     
  Branches      633      636       +3     
==========================================
+ Hits         2820     2833      +13     
  Misses         90       90              
- Partials       95       96       +1     
Flag Coverage Δ
unittests 93.83% <94.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrianPugh BrianPugh merged commit a898634 into main Jan 7, 2025
17 checks passed
@BrianPugh BrianPugh deleted the bugfix/annotated-inner branch January 7, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant