Use last command's help/version flags. #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of resolves #219.
The issue was that if a command wants to use a parameter like
--version
or--help
, the version/help flag system swallows it and gets priority. Previously, only the help/version flags of the root app were used; now the help/version flags of the resolved command are used (more intuitive/correct).@OrHayat with this PR, you can use
version
in your command as the following:I think I would like for the command to automatically have precedence over the help/version flags, but I don't think that will be possible until cyclopts v3.
Keeping this as a draft as I'm not totally satisfied with the solution; I want to think about it a little more.