-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bin #97
Improve bin #97
Conversation
Are tests failing because we actually need 2 autoloaders?? |
Could it be that tests are failing a year ago? |
@szepeviktor Thanks, that's much nicer. Yeah, Windows tests have never passed. I added some code to run the tests first with the classes, and then as the packaged phar. strauss/.github/workflows/main.yml Lines 41 to 46 in 53cb03e
strauss/tests/Integration/Util/IntegrationTestCase.php Lines 55 to 58 in 53cb03e
|
Very glad to contribute. |
Here's why the code was whack before... it was to do with running it from arbitrary directories. E.g. I'm in |
All right. |
I hope there is no need to load 2 autoloaders. The original bin had 2
if
-s.This PR introduces a straight-forward and explicit bin.