windows symlinks

BrianHenryIE · Apr 26, 2024 · 1cdb99c · 1cdb99c
1 parent 95d6905
commit 1cdb99c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/src/Cleanup.php b/src/Cleanup.php
@@ -68,7 +68,7 @@ public function cleanup(array $sourceFiles): void
                 if (is_link($absolutePath)) {
                     unlink($absolutePath);
                 } elseif (false !== strpos('WIN', PHP_OS)
-                    && substr(strrchr(strtolower($absolutePath), '.'), 1) === 'lnk'
+                    && stat($absolutePath)['nlink'] !== lstat($absolutePath)['nlink']
                 ) {
                     /**
                      * `unlink()` will not work on Windows. `rmdir()` will not work if there are files in the directory.
@@ -77,20 +77,7 @@ public function cleanup(array $sourceFiles): void
                      * @see https://www.php.net/manual/en/function.is-link.php#113263
                      * @see https://stackoverflow.com/a/18262809/336146
                      */
-                    rmdir($file->getRealPath());
-                }
-
-                if (is_link()) {
-                    /**
-                     * `unlink()` will not work on Windows. `rimdir()` will not work if there are files in the directory.
-                     *
-                     * @see https://stackoverflow.com/a/18262809/336146
-                     */
-                    if (false === strpos('WIN', PHP_OS)) {
-                        unlink($absolutePath);
-                    } else {
-                        rmdir($absolutePath);
-                    }
+                    rmdir($absolutePath);
                 }
 
                 if ($absolutePath !== realpath($absolutePath)) {

diff --git a/tests/Integration/Util/IntegrationTestCase.php b/tests/Integration/Util/IntegrationTestCase.php
@@ -91,7 +91,7 @@ protected function deleteDir($dir)
             if (is_link($file)) {
                 unlink($file);
             } elseif (false !== strpos('WIN', PHP_OS)
-                && substr(strrchr(strtolower($file->getRealPath()), '.'), 1) === 'lnk'
+                && stat($file)['nlink'] !== lstat($file)['nlink']
             ) {
                 /**
                  * `unlink()` will not work on Windows. `rmdir()` will not work if there are files in the directory.
@@ -100,7 +100,7 @@ protected function deleteDir($dir)
                  * @see https://www.php.net/manual/en/function.is-link.php#113263
                  * @see https://stackoverflow.com/a/18262809/336146
                  */
-                rmdir($file->getRealPath());
+                rmdir($file);
             } elseif ($file->isDir()) {
                 rmdir($file->getRealPath());
             } elseif (is_readable($file->getRealPath())) {