Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: filetype warnings #847

Merged
merged 4 commits into from
Dec 19, 2024
Merged

config: filetype warnings #847

merged 4 commits into from
Dec 19, 2024

Conversation

BrettMayson
Copy link
Owner

@BrettMayson BrettMayson commented Dec 18, 2024

Closes #841

Sorry for the renames on this PR, should've split that out, noticed it while working on this

image

Originally I had allow_no_extensions default to false, but on ACE that resulted in a lot of warnings. Should this be allowed by default?

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 68.40731% with 121 lines in your changes missing coverage. Please review.

Project coverage is 67.0%. Comparing base (65cb4e0) to head (258e755).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
libs/config/src/analyze/lints/c11_file_type.rs 50.9% 109 Missing ⚠️
libs/workspace/src/reporting/diagnostic/mod.rs 87.8% 4 Missing ⚠️
libs/config/src/model/ident.rs 0.0% 3 Missing ⚠️
libs/sqf/src/analyze/lints/s02_event_handlers.rs 25.0% 3 Missing ⚠️
libs/stringtable/src/analyze/mod.rs 50.0% 1 Missing ⚠️
libs/workspace/src/lint/macros.rs 75.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/config/src/analyze/lints/c01_invalid_value.rs 75.8% <100.0%> (ø)
...config/src/analyze/lints/c02_duplicate_property.rs 75.5% <100.0%> (ø)
.../config/src/analyze/lints/c03_duplicate_classes.rs 71.6% <100.0%> (ø)
...s/config/src/analyze/lints/c04_external_missing.rs 69.2% <100.0%> (ø)
...nfig/src/analyze/lints/c05_external_parent_case.rs 74.2% <100.0%> (ø)
...s/config/src/analyze/lints/c06_unexpected_array.rs 73.6% <100.0%> (ø)
...ibs/config/src/analyze/lints/c07_expected_array.rs 74.8% <100.0%> (ø)
.../config/src/analyze/lints/c08_missing_semicolon.rs 59.4% <100.0%> (ø)
.../src/analyze/lints/c09_magwell_missing_magazine.rs 60.9% <100.0%> (ø)
...nfig/src/analyze/lints/c10_class_missing_braces.rs 65.6% <100.0%> (ø)
... and 27 more

... and 1 file with indirect coverage changes

@PabstMirror
Copy link
Collaborator

we could always change allow_no_extensions default in a followup release so we have time to update projects

@BrettMayson BrettMayson merged commit b8fd218 into main Dec 19, 2024
37 checks passed
@BrettMayson BrettMayson deleted the config_filetypes branch December 19, 2024 03:12
@PabstMirror
Copy link
Collaborator

soundBegin / namesound seem to be just classnames

        animationMedic = "AinvPknlMstpSlayW[wpn]Dnon_medicOther";
        animationMedicProne = "AinvPpneMstpSlayW[wpn]Dnon_medicOther";
        animationMedicSelf = "";
        animationMedicSelfProne = "";

these are ace specific and reference (sorta) classnames

maybe it should enabled only for specific targets instead of starts_with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Detect if path of class' model property doesnt end in.p3d
2 participants