doctrine#7068 early exit if arguments are not sane for given lockMode

BreiteSeite · Feb 17, 2018 · 6b2225a · 6b2225a
1 parent 0336d5a
commit 6b2225a
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/lib/Doctrine/ORM/EntityManager.php b/lib/Doctrine/ORM/EntityManager.php
@@ -385,6 +385,18 @@ public function find($entityName, $id, $lockMode = null, $lockVersion = null)
         $class     = $this->metadataFactory->getMetadataFor(ltrim($entityName, '\\'));
         $className = $class->getClassName();
 
+        switch ($lockMode) {
+            case LockMode::OPTIMISTIC:
+                if ( ! $class->isVersioned()) {
+                    throw OptimisticLockException::notVersioned($className);
+                }
+            case LockMode::PESSIMISTIC_READ:
+            case LockMode::PESSIMISTIC_WRITE:
+                if (! $this->getConnection()->isTransactionActive()) {
+                    throw TransactionRequiredException::transactionRequired();
+                }
+        }
+
         if (! is_array($id)) {
             if ($class->isIdentifierComposite()) {
                 throw ORMInvalidArgumentException::invalidCompositeIdentifier();
@@ -446,25 +458,15 @@ public function find($entityName, $id, $lockMode = null, $lockVersion = null)
         $persister = $unitOfWork->getEntityPersister($className);
 
         switch (true) {
-            case $lockMode === LockMode::OPTIMISTIC:
-                if (! $class->isVersioned()) {
-                    throw OptimisticLockException::notVersioned($className);
-                }
-
+            case$lockMode === LockMode::OPTIMISTIC:
                 $entity = $persister->load($sortedId);
 
                 $unitOfWork->lock($entity, $lockMode, $lockVersion);
 
                 return $entity;
-
             case $lockMode === LockMode::PESSIMISTIC_READ:
             case $lockMode === LockMode::PESSIMISTIC_WRITE:
-                if (! $this->getConnection()->isTransactionActive()) {
-                    throw TransactionRequiredException::transactionRequired();
-                }
-
                 return $persister->load($sortedId, null, null, [], $lockMode);
-
             default:
                 return $persister->loadById($sortedId);
         }