Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a40_entityMetadata.js/a44_predicate.js Allow property paths with subtype #15

Closed
wants to merge 0 commits into from

Conversation

tschettler
Copy link
Contributor

OData 3 supports filtering on subtypes by using syntax such as follows:
Vehicle/Inheritance.Models.Bus/Capacity

This change allows for this type of filtering.

Original request:
https://breezejs.uservoice.com/forums/173093-breeze-feature-suggestions/suggestions/5655259-support-filters-for-multi-level-relationships-with

@tschettler
Copy link
Contributor Author

OK, so I merged the changes from the upstream master to my fork. I revoked my previous changes and added them to the relevant locations in the updated src files. I'm not sure why it added the ten extra files, My changes are confined to the following:
src/a40_entityMetadata.js
src/a44_predicate.js

Is this OK?

p.s. We've had this change in production working flawlessly for the last nine months. Breeze is currently my favorite library to work with, keep up the great work!

@tschettler
Copy link
Contributor Author

Wow, I'm still behind on commits... and I just authored this change a couple hours ago. This space seems to be in flux right now, I'll fix my pull request once it's a bit more stable.

@jtraband
Copy link
Contributor

This should be stabilizing over the next week or so. We've made some pretty big changes lately. ( although there have been only very minor breaking changes which i will call out in the next release) In terms of forking changes try to avoid checking in any changes to any doc/html files because these are automatically generated by a build script. i.e. check in just the .js files that have changed.

@tschettler
Copy link
Contributor Author

Sounds good, thanks @jtraband! My pull request is pretty minor in terms of changes, but it will make the framework much more flexible by allowing property resolution and OData queries to work across subtypes.

@tschettler tschettler changed the title a40_entityMetadata.js/a45_entityQuery.js Allow property paths with subtype a40_entityMetadata.js/a44_predicate.js Allow property paths with subtype Oct 2, 2014
@marcelgood marcelgood force-pushed the master branch 2 times, most recently from 29f111e to 4207098 Compare June 27, 2016 23:41
@tschettler tschettler closed this Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants