Skip to content

Commit

Permalink
server: Ignore byte fields in TestStatusSummaries
Browse files Browse the repository at this point in the history
TestStatusSummaries occasionally fails because of the asynchronous updating of
the "node liveness" table on the TestServer; occasionally, this update would
interleave with status summary generation in a way that threw off the
expectations of the test.

This is the second time this situation has happened; previously, this test
became flaky due to interleaving with the asynchronous recording of the
"NodeJoin" event by the TestServer. Because this has occurred multiple times,
instead of attempting to disable the Liveness heartbeat we will instead simply
relax the expectations of the test; it will no longer verify any "bytes" fields
on the status summary, checking only counts fields. The small value of the
verification of "Bytes" fields does not make up for the numerous headaches this
test has caused by occasionally failing incorrectly.

Fixes cockroachdb#9972
  • Loading branch information
Matt Tracy committed Nov 11, 2016
1 parent f70201f commit f171c5f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/server/node_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,6 @@ func compareNodeStatus(
"replicas.leaseholders",
},
[]string{
"livebytes",
"keybytes",
"valbytes",
"livecount",
"keycount",
"valcount",
Expand Down

0 comments on commit f171c5f

Please sign in to comment.