Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LightUp] Added FinishWithEmptyDirectRule test cases #748

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

jadeandtea
Copy link
Collaborator

Description

Added FinishWithEmptyDirectRule test.

Closes #575

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

The test passes successfully.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jadeandtea jadeandtea changed the title Adding FinishWithEmptyDirectRule test cases [LightUp] Adding FinishWithEmptyDirectRule test cases Feb 27, 2024
@jadeandtea jadeandtea changed the title [LightUp] Adding FinishWithEmptyDirectRule test cases [LightUp] Added FinishWithEmptyDirectRule test cases Feb 27, 2024
@Chase-Grajeda
Copy link
Collaborator

@Bram28 Could you review the test logic? Will be merged next week

@charlestian23 charlestian23 requested a review from Bram28 March 19, 2024 20:48
Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run successfully

@Chase-Grajeda Chase-Grajeda merged commit b1c8c2f into Bram-Hub:dev Mar 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants