Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 679 atomic true on empty #697

Merged
merged 5 commits into from
Dec 16, 2023
Merged

Issue 679 atomic true on empty #697

merged 5 commits into from
Dec 16, 2023

Conversation

Chase-Grajeda
Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda commented Dec 1, 2023 •
edited
Loading

Description

As detailed in #679 , atoms were being erroneously evaluated as True when setting the changed atom in the previous transition to type UNKNOWN from TRUE or FALSE. The following changes have been made to resolve the issue:

  • Generic Direct Rules now evaluate checkRuleRaw when the modified data list is empty
  • STT's checkRuleRaw for Direct Rules now returns an error message when modified data list is empty
  • TreeTent's SurroundTentWithGrass Direct Rule returns null when no input is provided
  • STT assertion for number of case rule children created updated from 2 to at least 1

Closes #679

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tested by using a newly generated file and the provided test in #679 and attempting to recreate the bug.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Chase-Grajeda
Fixed true on empty bug
c4a31c7 
Added IF check that returns false when a Direct Rule receives 0 modified cells
@Chase-Grajeda
Updated syntax for checkstyle
131858b 
Added braces to IF statement
@Chase-Grajeda
Bug fix progress
6372995 
Added condition to all DirectRule.Java that uses raw evaluation when no modified data is applied to the board;
Added null check for STT checkRuleRaw;
Updated STT case rule child count assertion from 2 to at least 1;
Added null check for TreeTent SurrountTentWithGrass Direct Rule.
@Chase-Grajeda Chase-Grajeda added bug Something isn't working short truth table labels Dec 1, 2023
@Corppet
Copy link
Collaborator

Corppet commented Dec 5, 2023

PR #697 to solve #679. 😏

@charlestian23 charlestian23 mentioned this pull request Dec 13, 2023
Merged
10 tasks
charlestian23
charlestian23 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good and work from my testing

@charlestian23 charlestian23 merged commit 69410ab into dev Dec 16, 2023
7 checks passed
@charlestian23 charlestian23 deleted the issue-679-atomic-true-on-empty branch January 30, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlestian23 charlestian23 charlestian23 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working short truth table
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chase-Grajeda @Corppet @charlestian23