510 nurikabe tests #539
Merged
510 nurikabe tests #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were initially commented out. This commit uncomments the tests and fixed all errors
This test was failing because there was only one black cell on the test board. Another reachable cell was added so the rule can be successfully applied.
The contradiction rule works for point (0, 1). This point was added to the "assertNull" list of points
The test failed on the original board because there is no black cells. The contradiction test it is checking against, isolatedBlackContradictionRule, requires at least one black cell.
|
Have you verified if these tests work? Like are these tests written correctly or did you simply just uncomment them? |
I have. But right now some lightup rules are failing the checkstyle. |
charlestian23
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several Nurikabe unit tests were previously commented out, presumably because they were failing and blocking the build. This PR resolves this problem.
Closes #(510)
Type of change
How Has This Been Tested?
All unit tests pass.
Checklist: