Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 502 #519

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Fixes 502 #519

merged 3 commits into from
Apr 4, 2023

Conversation

N-Desmarais
Copy link
Collaborator

  • fixed loadImage() to use a temp name so the settings aren't locked to colorblind permanently
  • made the preferences dialog dispose itself properly
  • added a reference to the rules frame in the preference dialog so preference updates can update the rules
  • added updateRules() function to ruleFrame that updates rule images

Description

fixes #502

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Corppet Corppet linked an issue Apr 4, 2023 that may be closed by this pull request
changing the color blind preference after loading a puzzle doesnt change the rule images. #502
Closed
Mbijur and others added 2 commits April 4, 2023 17:03
@Mbijur @charlestian23 @Corppet
Issue 513 (Bram-Hub#517)
a735dc1 
* Revert "Update PuzzleEditorPanel.java"

* Update SkyscrapersBoard.java

* input and updated descriptions for @return and @throws

* Update Puzzle.java

* Update ScrollView.java

* Update WrapLayout.java

* Update NumberTile.java

* Update DropShadowBorder.java

* Erased irrelevant code

* Update Puzzle.java

---------

Co-authored-by: Charles Tian <[email protected]>
Co-authored-by: Ivan Ho <[email protected]>
@N-Desmarais @Corppet
Fixes 502
26dbe5d 
* fixed loadImage() to use a temp name so the settings arent locked to colorblind permanently
* made the preferences dialog dispose itself properly
* added a reference to the rules frame in the preference dialog
* added updateRules() function to ruleFrame that updates rule images
@Corppet
Copy link
Collaborator

Corppet commented Apr 4, 2023

Please provide a meaningful title for your pull requests in the future. "Fixes 502" does not help unless I remember exactly what Issue 502 is (and there are a lot of issues so this is quite unlikely).

@Corppet Corppet merged commit 271b0c6 into Bram-Hub:dev Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corppet Corppet Corppet approved these changes

@charlestian23 charlestian23 Awaiting requested review from charlestian23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changing the color blind preference after loading a puzzle doesnt change the rule images.
4 participants
@N-Desmarais @Corppet @walkingjason @Mbijur