Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility to Java 11 #511

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Conversation

charlestian23
Copy link
Collaborator

Description

While working on the Short Truth Table puzzle editor, I wanted to use some features that were in Java 11. However, LEGUP was still only compatible with Java 8. This pull request will make LEGUP officially compatible with Java 11.

Changes made:

  • Updated source compatibility from Java 1.8 to Java 11
    • Allows programmers to use new language features from Java 11
  • Updated target compatibility to Java 11
    • Forces the lowest version that LEGUP can run on to be Java 11 (because of this, I have listed this pull request as a breaking change, since some people might not have Java 11 installed on their machines)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 requested a review from Corppet March 31, 2023 14:53
@charlestian23 charlestian23 marked this pull request as draft March 31, 2023 14:55
@charlestian23 charlestian23 removed the request for review from Corppet March 31, 2023 14:55
@charlestian23 charlestian23 marked this pull request as ready for review March 31, 2023 15:06
@charlestian23 charlestian23 requested a review from Corppet March 31, 2023 15:06
@Corppet Corppet merged commit 8169ea7 into Bram-Hub:dev Mar 31, 2023
@charlestian23 charlestian23 deleted the update_java branch March 31, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants