Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening Puzzle Bug Fixes #493

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Opening Puzzle Bug Fixes #493

merged 3 commits into from
Mar 14, 2023

Conversation

19690ao
Copy link
Collaborator

@19690ao 19690ao commented Mar 3, 2023

Description

From within the proof and puzzle editors, it wasn't possible to open a new puzzle. Now, opening a puzzle from within an editor should have the intended effect of opening a puzzle.

The ActionListener had the wrong function attached to it.

Closes #410
Closes #174

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I opened multiple files from either editor in succession.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 self-assigned this Mar 8, 2023
@charlestian23 charlestian23 self-requested a review March 8, 2023 20:18
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good

@charlestian23 charlestian23 merged commit 830d843 into Bram-Hub:dev Mar 14, 2023
@19690ao 19690ao deleted the OpenNewPuzzle branch March 18, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants