Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Yes/No/Cancel options to just Yes/No #453

Merged
merged 8 commits into from
Feb 24, 2023

Conversation

VortiganOfficial
Copy link
Collaborator

self explanatory

Description

Closes #424

Type of change

  • Enhancement (improvement to an already existing feature)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • The jar compiles and runs perfectly

@VortiganOfficial VortiganOfficial changed the title Changedd the yes/no/cancel options to just yes/no Changed the Yes/No/Cancel options to just Yes/No Feb 14, 2023
@charlestian23 charlestian23 self-requested a review February 16, 2023 13:04
@charlestian23 charlestian23 self-assigned this Feb 16, 2023
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good. However, the fact that the buttons aren't centered slightly bothers me. See the image below:
image

Can you change it so that the two buttons are centered?

@VortiganOfficial
Copy link
Collaborator Author

Will do!

@charlestian23
Copy link
Collaborator

Alright, it seems like you were right. FlatLaf formats the JOptionPane dialog like that, and it'll be a pain to change. So we'll just live with it. It's fine if it's not centered.

@charlestian23 charlestian23 self-requested a review February 24, 2023 21:15
@charlestian23 charlestian23 merged commit 76fb8f9 into Bram-Hub:dev Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants