Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing ENTER is the same as pressing Go putton in rule search #449

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Pressing ENTER is the same as pressing Go putton in rule search #449

merged 1 commit into from
Feb 13, 2023

Conversation

DavidColetta
Copy link
Collaborator

@DavidColetta DavidColetta commented Feb 10, 2023 •
edited
Loading

Description

Pressing ENTER with the rule search text box selected is the same as pressing the Go button next to the text box.

Closes #434

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 self-assigned this Feb 13, 2023
@charlestian23 charlestian23 self-requested a review February 13, 2023 14:46
charlestian23
charlestian23 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes, they work!

@charlestian23 charlestian23 merged commit 3eb76e7 into Bram-Hub:dev Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlestian23 charlestian23 charlestian23 approved these changes

Assignees

@charlestian23 charlestian23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidColetta @charlestian23