Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle #401

Merged
merged 31 commits into from
Jan 7, 2023
Merged

Gradle #401

merged 31 commits into from
Jan 7, 2023

Conversation

Millibyte1
Copy link
Collaborator

Description

  • Upgraded Gradle to 7.5.1
  • Replace Groovy Gradle build files with Kotlin
  • Updated and removed some dependencies
  • Added a GitHub action to deploy javadocs to Github Pages, hosted off the javadoc branch

Closes #289

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • GH page is already up and running with Javadocs from the gradle branch
  • Passed the automated build tests
  • The app launches. Since I only changed the build and deployment, that should be all

@Millibyte1
Unify quotes as double quotes in build files - 1st step to .kts trans…
3d96e13 
…lation
@Millibyte1
Make all dependencies short-form
2e3604d
@Millibyte1
Disambiguated assignment and invocation in 'build.gradle's
d498979
@Millibyte1
Disambiguated assignment and invocation in settings.gradle
31942ad
@Millibyte1
Hid some dependencies; removed unused apache commons dependency; remo…
403fcb0 
…ved legup-update entirely
@Millibyte1
Unify quotes as double quotes in build files - 1st step to .kts trans…
a5ec753 
…lation
@Millibyte1
Make all dependencies short-form
df8d48a
@Millibyte1
Disambiguated assignment and invocation in 'build.gradle's
fc6b38d
@Millibyte1
Disambiguated assignment and invocation in settings.gradle
eb61587
@Millibyte1
Hid some dependencies; removed unused apache commons dependency; remo…
92ed726 
…ved legup-update entirely
@Millibyte1
Upgraded to Gradle 7.5.1
2e2836c
@Millibyte1
Merge remote-tracking branch 'origin/gradle' into gradle
810e322 
# Conflicts:
#	build.gradle
@Millibyte1
Refactored, removed firebase as a dependency
1892c65
@Millibyte1
removed legup.user package, removed submit from ProofEditorPanel (rq.…
22c4d91 
… by Chase)
@Millibyte1
Merge branch 'dev' into gradle
b55a756
@Millibyte1
Groovy -> Kotlin
ffd9b6e
@Millibyte1
Merge branch 'dev' into gradle
76f9dcc
@Millibyte1
Added workflow to automatically publish docs to javadoc branch on p…
d386733 
…ush to dev
@Millibyte1
Changed trigger branch to javadoc-hosting for testing purposes
47b19d5
@Millibyte1
Merge pull request #398 from Millibyte1/javadoc-hosting
cc9b299 
merging to begin testing
@Millibyte1
merged dev into gradle
b345de6
@Millibyte1
Re-added apache commons dependency -- no longer unused
577020f
@Millibyte1
Removed capture of buildNativeWindows task to suppress unused val war…
31ce479 
…ning
@Millibyte1
Added flag to allow javadoc task to succeed with errors
cac893c
@Millibyte1
change trigger branch back to gradle to test on BramHub
3aa1901
@Millibyte1
Merge pull request #400 from Millibyte1/gradle
cd7d13e
@Millibyte1
Finished testing javadoc hosting. Switching trigger branch to dev.
a8838d4
@Millibyte1
Added link to the Javadoc site in README.md
7741635
@Millibyte1
Merge branch 'Bram-Hub:gradle' into gradle
8f90b73
@Millibyte1
Merge pull request #402 from Millibyte1/gradle
7352039
@charlestian23 charlestian23 marked this pull request as ready for review January 6, 2023 19:46
@charlestian23
Copy link
Collaborator

I'm assuming this is ready to review since this seems like it's been tested. @Chase-Grajeda you can mark this as in progress again if it's not done and I'll have someone pick it up during the next semester.

Chase-Grajeda
Chase-Grajeda approved these changes Jan 7, 2023
View reviewed changes
Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Chase-Grajeda Chase-Grajeda merged commit 9aa5f72 into dev Jan 7, 2023
@Chase-Grajeda Chase-Grajeda deleted the gradle branch January 7, 2023 02:15
charlestian23 added a commit that referenced this pull request Jan 7, 2023
@charlestian23
Revert "Merge pull request #401 from Bram-Hub/gradle"
fc870fd 
This reverts commit 9aa5f72, reversing
changes made to a555792.
@Chase-Grajeda Chase-Grajeda restored the gradle branch January 7, 2023 17:53
This was referenced Feb 10, 2023
Closed
Merged
@charlestian23 charlestian23 deleted the gradle branch March 31, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chase-Grajeda Chase-Grajeda Chase-Grajeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Millibyte1 @charlestian23 @Chase-Grajeda